fix: use RunContext with signal-aware root context for graceful shutdown #16056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client-stats command was relying on ctx.Done() inside run() to stop the ticker, but main() invoked app.Run(os.Args), which wraps RunContext(context.Background(), ...). Because the root context was not cancelable, ctx.Done() would never fire on process termination, preventing graceful shutdown. This change introduces a signal-aware cancelable root context using signal.NotifyContext and switches to app.RunContext(rctx, os.Args). As a result, when SIGINT or SIGTERM is received, rctx is canceled, the cli.Context’s embedded context is canceled, and the select case on ctx.Done() triggers, ensuring the ticker is stopped and the loop exits cleanly. This behavior aligns with how beacon-chain wires its context and fixes the shutdown semantics without altering run() logic.